Design comparison
Solution retrospective
All feedback is welcomed, thank you.
Community feedback
- @TedJenklerPosted 2 months ago
Hi @Abdelwahab942002,
Nice project! Here are a few suggestions:
I noticed that the link on "frontendmentor" doesn’t work at the moment. It would be good to fix this. Currently, only the new link on your GitHub is functional.
There are some responsiveness issues, particularly at around 406px wide where the <p> tag is pushed in by the margin of the <div>. Take a closer look at these margins and adjust as needed.
I observed that your site isn't wrapped in a container like <main>. I recommend exploring HTML5 semantic elements like <main>, <footer>, and <section> to make your code more structured, cleaner, and to improve accessibility.
I noticed that your site uses multiple <h1> tags. This isn’t recommended; <h1> should be used for the page title, with <h2> for headers and then <h3>, <h4>, and so on for sub-sections. Using HTML elements for structure rather than styling will greatly enhance your code quality.
Keep up the great work!
Best, Teodor
Marked as helpful0 - @SvitlanaSuslenkovaPosted 2 months ago
Hi, good job. But your image is not displaying, yhe problem is incorrect path, please, consider to change from <img src="/images/image-omelette.jpeg" alt=""> to <img src="./images/image-omelette.jpeg" alt="">
Hope you found this comment helpful :)
Marked as helpful0@Abdelwahab942002Posted 2 months ago@SvitlanaSuslenkova yah, thank you I have noticed this lately. Thanks for the advice.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord