Recipe page

Community feedback

• 

  P

  Artiom•120

  @Artiom-DeyevPosted 7 months ago

  Hello.

  The solution includes semantic HTML, but, if I can suggest, it could've been used a bit more. Not that it's rong, but, for example, instead of "div" in the main tag one could use "article" semantig tag or something like this.

  The html is well structured, readable, however, maybe it's a good idea to add gaps between blocks and also add some comments, it helps other developers to understand the code easier.

  The solution differs a little from the design.

  • The background color for the "main" section is different.
  • The width of the "main" section is narrower then the design.
  • Also, inside the "main" section other elements on a desktop breakpoint have different left and right paddings (it's 32px, it should be 40px, If I'm correct). I guess the approach was mobile-first, which is a very good approach, but it's better to review the desktop breakpoint after.

  CSS is good, good usage of tags and structure.

  Marked as helpful

  0

  ---

  

  Riyad Dine•80

  @riyadDinePosted 6 months ago

  @Artiom-Deyev thank you for the feedback. I will apply some change to all of that quickly

  1