Skip to content
Submitted 6 months ago

Recipe Page

JmsLpz•80
@JmsLpz
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Recipe page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

The things that I am most proud of are that I have applied those learnings I have read.

What challenges did you encounter, and how did you overcome them?

The challenging part I have encountered while creating this page is estimating the right sizes.

What specific areas of your project would you like help with?

I would like to have feedback on how to estimate approximately the right size of those things to be included on a page.

Community feedback

  • Dustin Knie•210
    @nullpuppyPosted 6 months ago

    I'd recommend looking at semantic html a bit, and trying to use things like article and section and such instead of relying on divs for everything. I might also recommend rethinking the naming of the CSS classes to reduce duplication, there's a few areas where at least some of the styling can be shared between sections.

    Regarding your request no how to estimate sizes of things, what I've done is pull the design or preview images were given into an image editor (like inkscape), and drawing boxes around various elements or features to figure out sizing. I've then started converting pixel sizes to rem by way of through font-size on a html, body and using that as my conversion unit. Hope that helps!

    0
  • Yasin Gunaydin•110
    @yasingunaydiinPosted 6 months ago

    Looks good! Do fix the bottom part by making the height of the main container taller.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord