Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Cleaner code would be preferred next time.
What challenges did you encounter, and how did you overcome them?It took me some time to get all of the small details resemble the design as closely as possible.
Community feedback
- @ilyesfennourPosted 3 months ago
It is a very nice implementation, but I have some notes:
In CSS, it is considered best practice to define colors using variables.
In the Accessibility, you forgot to add a role to the attribution section. Also, the headings should be in order from h1 to h6. You placed h1 first and then jumped to h3, which is not good for accessibility.
I hope that was helpful, Happy coding.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord