Skip to content
Submitted 7 months ago

Recipe page

KL•290
@TorHamm
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Recipe page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I have learned a lots from this project for example

  • how to use @media for responsive website
  • learned something about using child selector
What challenges did you encounter, and how did you overcome them?

It's took a while to understand about @media like the difference between device

What specific areas of your project would you like help with?

I think i did well here but if anyone know where i can improve i would appreciate if any give me advice about it.

Community feedback

  • Moa Davou•310
    @moadavouPosted 7 months ago

    Great work! 🎉

    I think you should use responsive units instead of px. You did use rem on border-radius in your media queries, but, apart from that everything is in px.

    If someone increases their default font-size, your site will not display these changes appropriately. This is bad for accessibility. Try to use rem for at least font-size and line-height.

    Here is an helpful article about units and accessibility: The Surprising Truth About Pixels and Accessibility

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord