Design comparison
Solution retrospective
I have learned a lots from this project for example
- how to use
@media
for responsive website - learned something about using child selector
It's took a while to understand about @media like the difference between device
What specific areas of your project would you like help with?I think i did well here but if anyone know where i can improve i would appreciate if any give me advice about it.
Community feedback
- @moadavouPosted 7 months ago
Great work! 🎉
I think you should use responsive units instead of
px
. You did userem
onborder-radius
in your media queries, but, apart from that everything is inpx
.If someone increases their default font-size, your site will not display these changes appropriately. This is bad for accessibility. Try to use
rem
for at leastfont-size
andline-height
.Here is an helpful article about units and accessibility: The Surprising Truth About Pixels and Accessibility
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord