Great work! 🎉
I think you should use responsive units instead of px
. You did use rem
on border-radius
in your media queries, but, apart from that everything is in px
.
If someone increases their default font-size, your site will not display these changes appropriately. This is bad for accessibility. Try to use rem
for at least font-size
and line-height
.
Here is an helpful article about units and accessibility: The Surprising Truth About Pixels and Accessibility
Marked as helpful