Design comparison
Solution retrospective
Just get better and better and learn something new with every challenge:
- Modifying UL and OL
- Finding a solution to the changed layout of the hero image for smartphones. Next time I will try to design for mobile first.
-
Custom point positioning of UL and OL: Played with list-style-position:inline and costome points with ::before. In the end, the simpler solution was to split the padding into ul/ol and li elements to move the points.
-
Different image layout for smaller screens: First I tried to somehow enlarge the hero image over the boundaries of the parent elements to get the desired layout on smartphones. I could not find a solution for this. Instead, I put a copy of the image in the html on top of the html structure and set it to display:none. On the media query I changed it to block.
I'm still not sure if my styling of lists and tables is optimal. The same applies to the media query with the changed image layout on the mobile phone. Would appreciate feedback on these issues, as well as anything else.
Community feedback
- @haquanqPosted 4 months ago
Hello @defPhisy 👋
Nice work on the solution, i can see you are using proper heading and list.
Here is something you can improve:
- Avoid using
div
whenever possible because it has no semantic meaning. Instead, consider usingarticle
orsection
to wrap part of the content (make sure provide it with a title/heading)
Have a nice day and enjoy coding!! 😁 😁 😁
Marked as helpful0@defPhisyPosted 4 months ago@haquanq: Thanks for your feedback. Still learning when to use div and when not 😁.
0@haquanqPosted 4 months ago@defPhisy: my experience is whenever i try to build something, i try to learn about all these native elements that offer the same feature first, if i can't find anything then i use
div
orspan
😁Marked as helpful0 - Avoid using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord