Design comparison
Community feedback
- @hassanmoaaPosted 9 months ago
Hello @Bredis79!
Great Job solving the challenge mate congrats 🎉
Some suggestions for improvements.
Use <main> to wrap the main content instead of <div>. * 📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
➖➖➖➖➖➖➖
Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>Other than that you're good, keep up the good work!
Marked as helpful0@Bredis79Posted 9 months agoHello @hassanmoaa!
thanks for your time to check my solution.
I used <main> tag to wrap main content, but then I used nested .main__wrapper as a <div>.
In headings I probubly made mistake. I used <h3> after <h1> and then <h2>.
Thank you for your advices...I appreciate it.
L.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord