Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I need some feedback to improve my self
Community feedback
- @Harsh-Kumar-DwivediPosted 8 months ago
Hi @HansKevin ,
Nice Solution !
I would suggest following:-
1.Prefer using
<main>
element instead of<div class="container">
.2.Replace
<div class="attribution">
with<footer>
element.3.Headings should be used in hierarchical order.
These will enhance your code, improve accessibility and make your markup more semantic.
Hope these suggestions are helpful !
Happy Coding !
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord