@f1r3place
Posted
hi there! congratulations on completing the challenge!
here's some feedback:
- the code is very much readable, it's great it's broken down into sections!
- there are some issues with the html:
- please add alt text to images! if there's only one thing to do for accessibility, that would be it.
- please don't use
<b>
tags as they carry no semantic meaning. instead you should use the<strong>
tag in this case to emphasize text.
everything else is fine as far as i can see.
- it's a bit weird you've only added one color as a custom property, you can just add every other one used there to make your life a lot easier
- i am not sure about this one, but instead of using
display: grid;
on your<tr>
's, you could useborder-collapse: collapse
on the table for borders to work - in the design all the things are flush on the inline sides (left-right), but in your implementation some things have indents
that's about it. good luck on your other challenges!