Design comparison
Solution retrospective
Getting the media queries to work right without having to remove the image from the main div.
What challenges did you encounter, and how did you overcome them?Getting the image to extend to the edges when viewed on mobile screen.
I used the div I had contained the image in and the body to remove margin and padding and add width.
What specific areas of your project would you like help with?Bullet point sizing and spacing
Community feedback
- @DavidCasanova83Posted 5 months ago
Hey, very good job ! Your design matches perfectly ā ā
Some tips about web accessibility :
Improve the Accessibility of Your HTML Code
Semantic Tags:
Use HTML5 semantic tags to improve the document structure.
-
Image Container:
- Replace
<div class="image-container">
with<figure class="image-container">
and add a caption if needed using<figcaption>
.
- Replace
-
Header:
- Add a
<header>
tag to group the title and description of the recipe.
- Add a
-
Sections:
- Use
<section>
for different parts such as ingredients, instructions, and nutritional information.
- Use
Contrast and Readability:
Ensure that your CSS colors provide good contrast for visually impaired users. Use tools like the Colour Contrast Analyser to check the contrast.
Navigation and Structure:
Add ARIA elements to improve navigation with screen readers. For example, use
aria-label
oraria-labelledby
for important sections.Links:
Ensure that links have descriptive text to clearly indicate their destination.
- For example, replace "Coded by Jesse Gile" with "Coded by Jesse Gile - Visit my website" to be more explicit.
Marked as helpful0@jessegilePosted 5 months ago@DavidCasanova83 Thanks! I refactored with your suggestions.
0 -
- @andrew-j-brownPosted 5 months ago
Hi Jesse!
As you mentioned bullet point sizing and spacing -
padding-left can be used on the list element to add some space between the li bullet and the li content. To shrink the bullet itself, you can use font-size. I'll place some examples below:
li { ... padding-left: 1rem; ... } ul > li::marker { ... font-size: 0.8rem; }
Hope this helps, and have a great day!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord