Recipe page

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hey, Great solution, You should be proud, You’re really nailing it. Just a few things I noticed that could make it even better…

  • In your <ol> and <ul> you have wrapped the text in a <p>, You dont need to do this as the <li> tag has already gave it semantic meaning, Screen readers have a specific way of announcing lists. Ensuring proper list structure aids screen reader output.

  • rem is better than px for margins and padding because it scales with the root font size, ensuring consistent spacing and responsiveness across different devices and user settings.

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪

  Marked as helpful

  0