Recipe Page

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

  • Your heading elements <h1><h3><h2>, Heading elements should be in sequentially-descending order (e.g., <h1>, <h2>, <h3>) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.

                      <h1>Simple Omelette Recipe</h1>
                          <h3>Preparation time</h3>
                      <h2>Ingredients</h2>
  

  • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

  @media screen and (min-width: 500px)
  

  I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

  0
• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  It looks like your Repository is set to private 🔏 so we are unable to provide some feedback on your code, You can change this following these steps,

  1. Open up your repository on Github, ✅
  2. Click on settings on the top nav bar, ✅
  3. Scroll down to the bottom, ✅
  4. In the red box you will see change repository visibility ✅
  5. Click on on Change visibility and select public. ✅

  Once you have done this your GitHub link should be viewable by everyone here on Frontend Mentor.

  0

  ---

  

  Feuzi•90

  @FeuziPosted about 2 months ago

  @Stroudy I've made the repository public.

  0
• 

  glowri57•130

  @glowri57Posted about 2 months ago

  Your GitHub repo is not visible. You probably set it to private. It would help if you changed it to public so that others could view your code and give feedback.

  0

  ---

  

  Feuzi•90

  @FeuziPosted about 2 months ago

  @glowri57 Repo is now public.

  0