Recipe Page

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 1 month ago

  Hi, this looks really good, well done!

  I'll quickly jot down some suggestions before I head off to work. I hope these are helpful!

  • use classes for styling not IDs. I've written a post about what IDs are for in HTML
  • There's no need for the spans wrapping every list item content. Keep html as simple as you can.
  • the css in this is using heavily nested selectors. Try to avoid this! Place classes directly on what you want to style and keep css specificity as low as possible. Writing css as you are doing now in larger / more complex projects will quickly become a maintenance headache.
  • well done for remembering to use header cells in the table! So many people forget to do that. To improve it add the scope attribute to those header cells so it's clear they are row headers and not the default column headers.
  • look up how to write good alt text on images. There are some great posts about this in the resources channel on discord.

  Marked as helpful

  1

  ---

  

  P

  Gustavo Gutiérrez•150

  @gustavo2023Posted about 1 month ago

  Hi @grace-snow thank you for taking the time to review my solution.

  I read your article about the use for IDs and I have a better understanding of how and when should I use them. I also read the article about selecting elements in JavaScript and I found it quite interesting and I plan to apply some of the recommendations you gave.

  I will also keep in mind to try to avoid using nested selectors and instead apply classes directly on the elements I want to styles.

  Thank you for the feedback!

  0
• 

  P

  Kamran Kiani•1,280

  @kaamiikPosted about 1 month ago

  Hi. Congrats for doing this challenge. I just wanna say try to use IDs for the relatioship between elements in html and java script. for CSS It's always better to use class names.

  2