@DylandeBruijn
Posted
@kalihari90
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of CSS custom properties
Things you could improve ✍️
-
Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try structuring your nutrition table using actual
table
,tr
,td
andth
elements. -
Even though you prefer a desktop first approach I recommend working mobile first. It helps you making your solution responsive writing a lot less code.
-
I recommend not setting a fixed height on your image. At the moment it warps when the viewport gets smaller. Leaving the
height
atauto
is fine in my opinion.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful