Submitted about 2 months ago

Recipe page - codigoTin

codigoTin• 100

@codigotin

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Recipe page

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am improving the CSS organization and HTML optimization to give better structure to the web in general. I would like to use more grids in a project.

What challenges did you encounter, and how did you overcome them?

In mobile mode, the padding of the elements except in the banner with the image, I had to add :not of CSS not to modify the HTML structure that was already done.

What specific areas of your project would you like help with?

I would like you to help me with the small details and to optimize the code according to best practices.

Community feedback

Dylan de Bruijn• 3,190

@DylandeBruijn

Posted about 2 months ago

@codigotin

Hiya! 👋

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things I like about your solution 🎉

Use of semantic HTML elements
Clear descriptive CSS classes
Use of CSS custom properties

Things you could improve ✍️

You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try using using relative CSS units like rem and em they make your layout more adaptable.
You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result. I also would suggest keeping the height of your image as auto so the aspect ratio is preserved. At the moment when the viewport gets smaller your image will warp.

I hope you find my feedback helpful! 🌟

Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

Happy coding! 😎

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord