Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
ok
What challenges did you encounter, and how did you overcome them?ok
What specific areas of your project would you like help with?ok
Community feedback
- @margaux-worksPosted 3 months ago
Hi Dimitri,
congratulations in submitting this solution, good job!
I had a look into your solution and noticed a couple of things that could be optimised.
- your HTML follows a clear and standard structure, which is really good!
- You also used semantic headings which is great for accessibility and SEO.
- you have linked twice the preconnect. You could remove one and only keep one.
- your image is missing an alt text which is important for accessibility and SEO.
- there is an excessive use of <br> tags for spacing, which is generally discouraged. CSS is usually a better solution to handle spacing.
- the table does not follow exactly the design that was provided to us. I can see you also created div, but here I would recommend to use the table tag. You can add the missing border by adding a border bottom on the td.
- your page currently looks nice on desktop, but is not responsive and adjusting well on smaller screens. I would recommend implementing media queries for this.
I hope this is helpful!
Keep up the good work :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord