Design comparison
Solution retrospective
The design of it, I managed to breakdown the layout to be very semantic and also design it very easy.
What challenges did you encounter, and how did you overcome them?In the nutrition the break lines i had some trouble with, next time i will not use table and I will nest them each in a div
What specific areas of your project would you like help with?Anything that make me code more efficient.
Community feedback
- @DylandeBruijnPosted 4 months ago
@Simone-cpu-debug
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Responsive
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve ✍️
-
Using
<table>
,<td>
and<th>
to structure and style the nutrition table. It is possible to achieve the same result and your code would be more semantic. -
Try experimenting more with Flexbox.
-
It's not necessary to wrap your image in a
<div>
, you could remove the wrapper and style the image by itself.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful1@Simone-cpu-debugPosted 4 months agoHey! @DylandeBruijn Thank you for taking some of your time to help me with my project. One thing that i want to tell you is that i tried with <table>, <td> and <th>, but a problem i had was the line between them, every time I tried there was a tiny space between the 2 lines and i couldn't connect them. Would it be okay if you can help me out here? Looking forward to hear from you! Have a nice day/night!
0@DylandeBruijnPosted 4 months ago@Simone-cpu-debug
Hiya! That's probably because of border-collapse. By default this is set to
border-collapse: separate;
on thetable
element. You could try setting it toborder-collapse: collapse;
Marked as helpful1@Simone-cpu-debugPosted 4 months agoOh I see now, thanks @DylandeBruijn ! I'm really grateful for your time and help. Have a good day/night!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord