Recipe card

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @Simone-cpu-debug

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Responsive
  • Use of semantic HTML elements
  • Clear descriptive CSS classes
  • Use of CSS custom properties

  Things you could improve ✍️

  • Using <table>, <td> and <th> to structure and style the nutrition table. It is possible to achieve the same result and your code would be more semantic.

  • Try experimenting more with Flexbox.

  • It's not necessary to wrap your image in a <div>, you could remove the wrapper and style the image by itself.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1

  ---

  

  Simone-cpu-debug•120

  @Simone-cpu-debugPosted 4 months ago

  Hey! @DylandeBruijn Thank you for taking some of your time to help me with my project. One thing that i want to tell you is that i tried with <table>, <td> and <th>, but a problem i had was the line between them, every time I tried there was a tiny space between the 2 lines and i couldn't connect them. Would it be okay if you can help me out here? Looking forward to hear from you! Have a nice day/night!

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @Simone-cpu-debug

  Hiya! That's probably because of border-collapse. By default this is set to border-collapse: separate; on the table element. You could try setting it to border-collapse: collapse;

  Marked as helpful

  1

  

  Simone-cpu-debug•120

  @Simone-cpu-debugPosted 4 months ago

  Oh I see now, thanks @DylandeBruijn ! I'm really grateful for your time and help. Have a good day/night!

  1