reasponsive page using flex

Community feedback

• 

  Marzuk Sanni•1,360

  @ZukizukPosted 9 months ago

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <div class="container"> with <main class="container">. the main tag should hold the main content of the page so consider correcting that.

  The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.

  The heading elements are H1, H2, H3, H4, H5, and H6 with H1 being the highest (or most important) level and H6 the least. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. The heading elements are H1, H2, H3, H4, H5, and H6 with H1 being the highest (or most important) level and H6 the least. In your code I didn't see any h1 tag but h3 which is wrong so consider fixing that. Please note that if there's no h1. there shouldn't be an h2 or h3. But again every page need an h1.

  Also if you want to center your card. You could have used align-items: center; since you used display: flex; to center the card vertically

  I hope this feedback is helpful

  Other than that great job

  0

  ---

  

  Alexworldwid•540

  @AlexworldwidPosted 9 months ago

  @Zukizuk ohh thanks you are very right i underestimated the need for the semantic elements i'll fix that

  0