React,Redux,Sass

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Akinyemi, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the flag images
  • use ul element for the details text of country instead of multiple p
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

  Hope this help! Happy coding 😉

  1

  ---

  

  Akinyemi gabriel•510

  @Akinyemi04Posted about 2 years ago

  @denielden Thanks For The correction It helps alot i'll see to it..

  1

  

  Akinyemi gabriel•510

  @Akinyemi04Posted about 2 years ago

  @denielden just finish fixing up the code your review will be much appreciated. Hope to Here From You Soon

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @Akinyemi04 you are welcome and keep it up :)

  0