Design comparison
Solution retrospective
Hello everyone! This is my second exercise with React.js. This challenge gave me the opportunity to use and practice for the first time with the react-router-dom and therefore with the single-page-applications.
Any advice and feedback is welcome!
Unfortunately in the deployment I am encountering a problem that was not there during the development: in smartphone mode the select-container covers the first card of the countries.
Another problem I encountered is the fact that, in the route dedicated to country-details, if I change country by clicking on the borders button, when I click on the back button of the browser I cannot go back in the browser-history: the url changes correctly, but the UI does not change.
Thanks so much!
Community feedback
- @sergiobarriaPosted over 3 years ago
Hi Aurora, Your solution looks great (at least on my browser), I don't know if you already fixed it or not but I don't see the troubles you mention.
My only suggestion would be in the dark mode to apply the dark color to the entire body and not just to the container with the max width of 1440px. Is not a big deal really, I just think it looks weird with two white stripes on left and right side on larger screens.
Again, great job!😁 Happy coding!!
1@Auro-93Posted over 3 years ago@sergiobarria Hi Sergio, thank you very much!
I double checked the project today and the style works correctly again (it was probably some browser problem). Unfortunately, the browser back button still does not work correctly in the route of the individual countries.
Thanks a lot for the style tip too - it's something I actually had to fix, but forgot
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord