Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

React?JS library Semantic HTML5 markup CSS3 JSX Flexbox Mobile-first

Richouf95ā€¢ 30

@Richouf95

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I created this component with React.js

Please review my code for improvement.

You'll find the link in the project description.

Community feedback

Marcos Travagliniā€¢ 4,920

@Blackpachamame

Posted

Greetings! you have done a great job šŸ˜Ž

šŸ“Œ Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="Component"> to a <main class="Component"> and the <div class="attribution"> to a <footer class="attribution">
  • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
  • Apply max-width: 100% to your img so that it occupies the correct width within the container
  • Add a max-width to your container with class card to prevent the image from spreading too far
  • Do not apply height: 90vh in your Component, instead add the following in the App class:
.App {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
      flex-direction: column;
      gap: 20px; /* Separate the main from the footer */
}
  • You have linked the favicon in your head, however, you did not upload it to your repository, therefore, it is not visible

Marked as helpful

1

Richouf95ā€¢ 30

@Richouf95

Posted

Hello @Blackpachamame

Thank you for your time and suggestions.

I integrate them immediately.

I've applied your suggestions and they don't seem to affect the visual result in any way.

You can check once more to make sure I've incorporated the corrections.

Many thanks again

0
Marcos Travagliniā€¢ 4,920

@Blackpachamame

Posted

@Richouf95 The idea is to reach the same visual result with the most organized code.

1
Richouf95ā€¢ 30

@Richouf95

Posted

@Blackpachamame Thanks again

0
Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @Richouf95!

Your solution looks great!

I have a suggestion for improvement:

  • For semantic reasons, use <main> to wrap the main content instead of a <div>. The tag <div> has no semantic value.

šŸ“Œ This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

1

Richouf95ā€¢ 30

@Richouf95

Posted

Hello @danielmrz-dev I take note of your suggestion. I will integrate the corrections immediately.

Thank you very much for your attention to my project and for the enriching suggestions.

You can check once more to make sure I've incorporated the corrections.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord