@Blackpachamame
Posted
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="Component">
to a<main class="Component">
and the<div class="attribution">
to a<footer class="attribution">
- You can apply
display: block
to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements - Apply
max-width: 100%
to yourimg
so that it occupies the correct width within the container - Add a
max-width
to your container with classcard
to prevent the image from spreading too far - Do not apply
height: 90vh
in yourComponent
, instead add the following in theApp
class:
.App {
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
flex-direction: column;
gap: 20px; /* Separate the main from the footer */
}
- You have linked the
favicon
in yourhead
, however, you did not upload it to your repository, therefore, it is not visible
Marked as helpful
@Richouf95
Posted
Hello @Blackpachamame
Thank you for your time and suggestions.
I integrate them immediately.
I've applied your suggestions and they don't seem to affect the visual result in any way.
You can check once more to make sure I've incorporated the corrections.
Many thanks again
@Blackpachamame
Posted
@Richouf95 The idea is to reach the same visual result with the most organized code.
@Richouf95
Posted
@Blackpachamame Thanks again