React.js Ip Address Tracker

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, there, Kacper! 👋

  Good work on this challenge! Your solution works rather well (apart from the search feature, as Matt mentioned) and is responsive! 👍

  I just suggest taking a look at your solution report and making the input element accessible. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Kacper•205

  @gacburPosted almost 4 years ago

  Thank you for your good advice! appreciate you :)

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  Hey Kacper, nice work on this challenge! You've done a good job with the styling. At the moment, I'm getting a 422 Unprocessable Entity error when I try to search for a domain. So that's worth looking into. I'd also recommend trying to resolve the accessibility error in the report.

  Have you ever tried using min-width media queries instead of max-width? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.

  Keep up the great work!

  1
• 

  Kacper•205

  @gacburPosted almost 4 years ago

  Hello Matt, thanks for the feedback! I will look into the errors and try to fix them, I have never tried the mobile-first approach, but I must say it sounds great and very convenient, I will get into it :) Thanks for the valuable advice, I really appreciate your help!

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  @gacbur no problem! Mobile-first will probably feel odd to start with but keep with it. It's a great workflow!

  0

  

  Kacper•205

  @gacburPosted almost 4 years ago

  I will! Thanks.

  0