Design comparison
Solution retrospective
Currently I'm learning ReactJS and this is one of the projects I've built. If you any suggestion, feedback let me know, please
Community feedback
- @buneeIsSloPosted about 2 years ago
Hey! @Ibrohim2001, You've done really well for someone new to React. I am a beginner myself and here are a few things I think you could improve:
-
You didn't need to create the divider. FEM has provided a divider pattern as an SVG(in your
img
directory), you're better off using that. -
Your app will not generate any advice on Firefox. This happens because of the default caching behavior on all browsers. You can fix this by adding
fetch(API_URL, { cache: 'no-cache' } )
in your fetch method. -
Initally your advice card is empty on load. It is good practice to set temporary placeholders, rather than empty strings.
Hope this helps :)
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord