Design comparison
Solution retrospective
I'm new to react, does my code readable and good practice? Any advices are appreciated. Thank you for your time
Community feedback
- @hardy333Posted about 3 years ago
Hey try to get a little closer look to design files and style guides , they are very important and your design needs to be little more close to design files.
Other then that on react side interactive parts work fine -- GOOD JOB with that.
Hope you will fix design soon and your solution will become very good..
Marked as helpful3 - Account deleted
Not good at React myself so I won't touch on that.
Your solution works, but the styling needs a lot of work and you should be fine.
-
Remove the border on the 'start my trial' button with
border : none
'cause I can see it's still there. -
There needs to be some between those checks and the text next to it.
-
I don't think the color of the card is the right one, and there's a couple of typos.
Keep coding👍.
Marked as helpful0@docuong0912Posted about 3 years ago@thulanigamtee okay, thanks you so much, i was so concentrated in the javascript that i forgot about the styling, i'll keep that in mind and be careful next time, thanks for your time
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord