@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
marginorpadding.
- We don't need to use
marginandpaddingto center the component both horizontally & vertically. Because usingmarginorpaddingwill not dynamical centers our component at all states
- You already using
Flexboxfor layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
#root {
min-height: 100vh;
align-items: center;
}
- Now remove these styles, after removing you can able to see the changes
#root {
margin: 50px;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
@INFLAMER07
Posted
Jai shree ram 🙏i know these things but im not wanting my time rn on css and stuff and i dont think its possible to complete site under 3 hours with proper css anyways thankyou for your consideration @0xAbdulKhalid
@0xabdulkhaliq
Posted
@INFLAMER07 Glad you found it helpful ! 🤠
@0xabdulkhaliq
Posted
BTW @INFLAMER07, can i know the meaning of "Jai Shree Ram" ?
@INFLAMER07
Posted
It's just a greeting that we use @0xAbdulKhalid
@0xabdulkhaliq
Posted
Bro @INFLAMER07, but the google says "Victory to Lord Ram".
I don't know why you're saying this to me as "Victory to Lord Ram".
Is this a greetings bro ?
@INFLAMER07
Posted
@0xAbdulKhalid it is a greeting and it definitely not means victory to lord ram . maybe you are from south and people don't use it that often over there but when you travel to north thats something you might find
@0xabdulkhaliq
Posted
Yeah you're right @INFLAMER07 people from south never used that, and i'm eager to know the meaning of the sentence from you.
Can you explain the meaning for that ?
Because Google may fail sometime but human can provide the right data!
