Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive News_signIn using React.js

VIJAYā€¢ 190

@VJYGOUR

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This project is good amazing,I learn a lot by doing this project

Community feedback

T
Chamuā€¢ 13,110

@ChamuMutezva

Posted

Hi VIJAY

So far so good with your project. Here are some areas that needs addressing:

  • alt img elements should have an alt value. Decorative images should have an empty value , if not decorative, then the value should describe the message in the image
  • landmark elements such as main should be part of your HTML structure . Other landmark elements include the header and footer elements. You can get a detailed explanations about these elements from MDN
  • when you are presented with various images , where you are a given an image to display for mobile, and another for desktop etc - they are recommended practices that should be used with the image element. One of them is the picture element. Using JS is not a recommended practice even though it may work.
  • the input element is associated with a label element whereby the label should have an htmlFor attribute whose value is the id of the input element.
  • css styling should follow a mobile first approach

Marked as helpful

0

VIJAYā€¢ 190

@VJYGOUR

Posted

@ChamuMutezva thankyou for correcting me , in the next project i will work on these areas and pay attention to these details.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord