React time tracking

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Valentin D. Wow! This is a stupendous solution! You really nailed it, your grid layout is really fine here's a few tips that I think might be useful:

  • Instead of declaring grid-columns like this grid-template-columns: 1fr 1fr 1fr 1fr;, you could use grid-template-columns: repeat(4, 1fr);
  • At the screen width of 900px, instead of using 1 column, You could try 3 or 2 columns and then you later move on to 1 column when your screen becomes to small to handle multiple columns.
  • You might want to include a level one heading (an <h1> tag) most preferably on the name "Jeremy Robson" in your case. This will fix your accessibility issue. I think you nailed it with your grid! Keep up the good work and happy coding!

  Marked as helpful

  1

  ---

  

  Valentin D.•160

  @Valentin-DrPosted over 2 years ago

  @tesla-ambassador Thank you so much for your kindness and your tips, I indeed forgot the h1 tag, which is pretty embarassing...

  And I did not know about using repeat in my grid-template-columns property, that will be useful for sure !

  Thank you :)

  0