React, tailwindcss, API

Community feedback

• 

  Mehmet Akif AKKUŞ•170

  @mehmetakifakkusPosted over 1 year ago

  Hey Gideon, I like your project, but here are some marks to revisit on your project.

  1. It seems that details page is not created. You can create details page for the country clicked.
  2. It seems that search filter does not work. You can add the feature that allows user to type and show the countries that fulfills the searching criteria.

  0

  ---

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  Thanks @mehmetakifakkus but those features you mention work in the deployed site on chrome. I'm surprised to hear its not working on your end. Pls can you check again

  0

  

  Mehmet Akif AKKUŞ•170

  @mehmetakifakkusPosted over 1 year ago

  @DrPlain Is that this website: https://countries-made-easy.netlify.app/

  0

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  Yeah @mehmetakifakkus. I noticed that if the device has local setting set to darkmode, it tends to render darkmode automatically but works well if a device local setting is removed from darkmode.

  Then about country details, I though the challenge is that when a country is searched it should open up a country detail for that country. That works. What doesn't work is clicking on a displayed country doesn't take one to that country. Is it the same from your device?

  0

  

  Mehmet Akif AKKUŞ•170

  @mehmetakifakkusPosted over 1 year ago

  @DrPlain My understanding about the challenge is that: when a country is searched it should filter the countries, because multiple countries may possibly satisfy the search.

  Please visit this webpage to see example filtering:

  • https://github.com/mehmetakifakkus/rest-api-countries/blob/main/screenshots/lightMode-mainpage.png

  Here search term is "Po", and you will see that 4 countries satisfies the term namely, Portugal, Poland, Singapore, and French Polynesia

  About country details, clicking on a country does not still work.

  0

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  Thank you so much for taking your time to point out your observation @mehmetakifakkus.

  I interpreted the search country by input to mean entering the full country name and not to be filtering as you are entering.

  I realised I didn't implement the clicking on a country part. Thanks for your feedback. Try searching by a country full name to see if it works.

  I will add more solutions

  0

  

  Mehmet Akif AKKUŞ•170

  @mehmetakifakkusPosted over 1 year ago

  @DrPlain You are welcome. Glad to share my insights and also glad to hear from you for my projects as well.

  • I checked again, yes, full name input works great. For partial word search, you can use String.prototype.includes(). This function can help while filtering.
  • Another thing for searching is you can return the result immediately while typing. You can use the onChange event of the input element.

  See you on your other projects!

  Marked as helpful

  0

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  Thanks for the suggestions @mehmetakifakkus. I will checkout yours

  0

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  I have implemented the partial word search and the ability to click on any country to see more details. Help me check it out @mehmetakifakkus

  0

  

  Mehmet Akif AKKUŞ•170

  @mehmetakifakkusPosted over 1 year ago

  Hey @DrPlain, It works perfectly!

  It is so nice that you did it in only one day, congrats Gideon!

  After this you can have a look at this one, this interactive comments project is so instructive.

  Marked as helpful

  0

  

  Gideon Obiasor•80

  @DrPlainPosted over 1 year ago

  Thank you Mehmet. I will definitely check out the recommended challenge. @mehmetakifakkus

  0