React + SASS website to consume REST Countries API

Community feedback

• 

  Tomi•565

  @Tomi-pterPosted over 2 years ago

  Hi Danilo, a suggestion:

  • As @denielden pointed out to me, to use the name as the href parameter you have to parse it to string url. Refer to this article on URL parsing for more info.

  Hope this helps 👍🏾

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Danilo, I took some time to look at your solution and you did a good job!

  I have some tips for improving your code:

  • If I type a search query that doesn't give any results nothing happens, you might add something like "0 results"
  • I would also add a query reset button
  • in the dark mode the header and input text remains black
  • as soon as a country page opens i see "Country not found!"
  • if I click to the border countries inside the details page give me Not Found

  Also I suggest you to use a custom hook for data recovery -> read here. You can also see practical usage in my solution

  Overall you did well 😉

  Hope this help and happy coding!

  0