Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

React + SASS website to consume REST Countries API

Danilo Vilhenaβ€’ 160

@danilovilhena

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Community feedback

Tomiβ€’ 565

@Tomi-pter

Posted

Hi Danilo, a suggestion:

  • As @denielden pointed out to me, to use the name as the href parameter you have to parse it to string url. Refer to this article on URL parsing for more info.

Hope this helps πŸ‘πŸΎ

1
Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hi Danilo, I took some time to look at your solution and you did a good job!

I have some tips for improving your code:

  • If I type a search query that doesn't give any results nothing happens, you might add something like "0 results"
  • I would also add a query reset button
  • in the dark mode the header and input text remains black
  • as soon as a country page opens i see "Country not found!"
  • if I click to the border countries inside the details page give me Not Found

Also I suggest you to use a custom hook for data recovery -> read here. You can also see practical usage in my solution

Overall you did well πŸ˜‰

Hope this help and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord