React + sass + flex

Community feedback

• 

  Jayanth•190

  @gjaynir0508Posted about 3 years ago

  Hi, I faced the same problem and found the solution in the following article.

  https://dequeuniversity.com/rules/axe/4.0/landmark-no-duplicate-main#:~:text=Rule%20Description%20It%20is%20a%20best%20practice%20to,the%20document%20has%20at%20most%20one%20main%20landmark.

  Hope this helps.

  Marked as helpful

  1

  ---

  

  E.sa•300

  @E-saPosted about 3 years ago

  @gjaynir0508 Thank u very much i check the link :)

  0
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  Hey, this is a pretty awesome solution. I like it.

  1. if you want all page content to be contained within landmarks, you should make sure that all your "divs, image tags, buttons, forms... etc." are contained in landmarks like "Section, article, main, footer... etc." to enable people that are using screen readers to access your site.
  2. I think there's some sort of bug when I choose clear completed because it also clears those that I haven't marked as completed.
  3. Also make sure that all your "li" elements are contained within "ul" i.e. (<ul><li></li></ul> and on the same note, you can't have a div as a child element of an li.

  4.Make sure that you only have one main landmark. I recommend that you replace your second main landmark with a section or article. 5. Remember to add labels to form elements to help people that use screen readers to access your site. Otherwise, I think this is a very good solution! Keep up the good work and keep on coding! Kudos!

  Marked as helpful

  1

  ---

  

  E.sa•300

  @E-saPosted about 3 years ago

  @tesla-ambassador

  I try to do as you said for the land mark, thanks

  I know its <ul><li>, but i made a dumb mistake and put div inside <ul> and i got warning for that so i changed <ul> to <div> (fast and lazy solution, i will fix it ;) )

  Im gonna fix clear completed too.

  And again thank u for you time checking my code and writing this comment i appreciate it. :)

  0

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  @E-sa You're very welcome! Am glad I could help

  1