React, React Router (v6), Styled Components

Community feedback

• 

  MikevPeeren•2,100

  @MikevPeerenPosted about 3 years ago

  Hey @thunderhead27,

  Good job on finishing this one!

  The bug you are relating too could be caused because the screenshot is taken before everything is loaded. That was the case for my problems with screenshots.

  When I navigate I get a brief flash of white before seeing the other pages. This is only when I navigate to the Home and from Home. When I navigate from destination to crew for example it does not appear. Maybe you forgot some kind of config with React Router 6 ?

  I also think this project is the perfect example to add some nice animations/transitions for example the white circle in the technology tab, therefor I like the animation of the Explore, but I think there could be more in it.

  When I inspect element of your project and move from desktop to mobile I can see the navigation do a weird transition, I am not sure if this is intended ?

  Also on the mobile variant 375px and 320px I see the white background, I think because not all of the width and height is used.

  But like I said good job on finishing this one 💪

  Marked as helpful

  1

  ---

  

  John Choi•380

  @thunderhead27Posted about 3 years ago

  @MikevPeeren

  Thanks for the helpful response, Mike. I think the bug could be related to the Styled Components CSS. I finished a landing page for a website in another exercise with React and Styled Components, but without React Router v6, and had the same issue with the line break in a button: https://www.frontendmentor.io/solutions/react-with-styled-components-30AfvsFp7

  As far as the navigation transition goes, that was part of the slide out animation (executed by clicking on the hamburger icon) for the mobile layout that spilled into the other responsive viewports. I didn't think it'd be an issue since it wouldn't be visible on a mobile or tablet.

  Yes, I should add some animations to the sliders. I completely forgot about that.

  Lastly, I do see that bit of white on the bottom there on the smaller layouts. Thanks for the heads up!

  0