Design comparison
SolutionDesign
Solution retrospective
Hello, It is my second app built using ReactJS. I learn React myself. I'd like somebody's opinion about the quality of the code. Thank you.
Community feedback
- @grace-snowPosted over 3 years ago
Hi
It's great that you're self learning React. But it is very important not to let the foundations go, like good semantic html structure, accessible code, honoring the design etc when picking up frameworks. This is not accessible at the moment and doesn't look that close to the design yet.
I recommend you
- run an audit like lighthouse or something and start building that practice into your workflow
- try out screen readers to build understanding of how important accessible code is
- update html structure to address those issues
- read up on when to use checkboxes vs radios for toggles
- read up on how to make range sliders accessible
- update the styles to be closer to the design
Good luck
0@alexeykuz-sysPosted over 3 years ago@grace-snow Grace, thank you. It is so beneficial when an experienced professional checks the code.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord