@huyphan2210
Posted
Hi, @Kamelek1337
I took a look at your solution and I have some thoughts:
- Your
body
covers the full viewport because ofmin-height: 100vh
, but your#app
and.container
don’t. In situations like this, I usually apply Flexbox to the body and#app
, withflex-direction
set to column, and useflex: 1
on#app
and.container
to make them stretch properly.
body {
display: flex;
flex-direction: column;
min-height: 100vh;
}
#app {
display: flex;
flex-direction: column;
flex: 1;
}
.container {
flex: 1;
/* Your styles here*/
}
This setup ensures both #app
and .container
expand to fill the available space of the body
.
- You're hardcoding the
width
andheight
of.container
and<main>
. It also looks like you're not using media queries to make the form responsive (it seems like you're using React state to change its class, which is another valid approach). However, on viewports between601px
and1200px
, the form isn't centered or responsive. I'd suggest removing the hardcodedwidth
andheight
, and using media queries to handle responsiveness.
Hope this helps!
Marked as helpful
@Kamelek1337
Posted
Hi, @huyphan2210 !
Thank you for your feedback. I will implement the changes you suggested in the near future.
Best Kamil