Skip to content
Submitted about 2 years ago

React, MUI, CSS, HTML

Jacqui•10
@jacode77
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This project was easy but wanted to start on something simple as I get more familiarised with MUI. I changed the background colour so it looked closer to what was provided in the image since the code provided isn't the same.

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @jacode77, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Jacqui•10
    @jacode77Posted about 2 years ago

    Hi @correlucas,

    Thank you for your feedback! I was so pleased with myself to finish so quickly I forgot to ask for feedback. After deploying I noticed some changes should be made and will certainly take your suggestions on board. A 20% reduction of code would be great as well as making the document better for accessibility.

    Thanks again!

    0
  • Quang Hung Pham•470
    @pqhung3007Posted about 2 years ago

    I also chose this challenge as a kick-start; it seems like what you did is much better than mine. Keep sharpening your expertise and be consistent throughout the process!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord