React JS with SCSS + BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, great job once again, Felipe Oliveira! 🙌

  Your solution looks good, responds well, and everything works great! 👏

  Keep coding (and happy coding, too)! 😁

  0
• 

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  Hello again Felipe, amazing job on the challenge.👍👍 It functions and responds well. As usual feedback below.

  Accessibility

  When I enabled some tablets, I tried tabbing through them and was unable to do so. Mainly due to the.table tablet--remove-icon and .tablet elements being divs. I would suggest using a button or anchor tag. By default they would have keyboard support for spacebar/enter keydown and tabbing.

  Design

  • The h1.Job__position could use an anchor tag with a hover state.
  • Minor changes like adding a font-weight to your tablets and maybe decrease font size for your Job__meta

  Great job 👍, can't wait to see your next solution

  0

  ---

  

  P

  Felipe OG•730

  @felipeogPosted almost 4 years ago

  Hello, @artimys!

  Good point on the accessibility, I didn't do the tabbing test. Good catch on the design details too.

  Thanks for the feedback!

  0