Design comparison
Community feedback
- @katjadanilovaPosted almost 2 years ago
Hi, Vivek!
I really liked some of your design choices; rolling dice in particular was nicely done!
I noticed that the HTML and Accessibility report had some complaints. This is because it is expected to have button texts and image descriptions, so that people who rely on screen readers can understand what is happening on the screen. To make it accessible for a screen reader, you could use a
div
instead of a button and addaria-label="Get another quote"
.Additionally, on hover, you could add a glowing effect behind the dice container, as it was offered in the task.
Hope it helps :)
0@czechoslovakia36Posted almost 2 years ago@katjadanilova Hi Katja. Thank you for taking your time and reviewing my solution. I did not know that you can call onClick event on div tag but, now I know. I will make these changes.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord