react js, react router, bootstrap, scss, framer motion, firebase.

Community feedback

• 

  Marvin Baga•310

  @mjbagaPosted over 2 years ago

  Hi, Jessica. Good work on the challenge.

  I've checked your code and here's some feedback:

  • Try adding a container for max-width on the breakpoints so that the site won't be very stretchy, especially when reaching very wide screens.
  • For file organization, maybe try breaking down your header and footer on their own components.
  • You can look into mobile-first styling for handling responsiveness. It's a concept where you style out your mobile CSS rules then add media queries as you increase screen size like for tablet or desktop.
  • For this last one, just a personal preference (you can ignore haha), I'd say either just go full Sass or full utilities library, but I'd go with Tailwind as it's really more flexible than bootstrap, especially with responsiveness.

  That's it. I've also done Designo, you can check it out. Hope this helps and happy coding!

  Marked as helpful

  1

  ---

  

  Jessica Dubem•50

  @JessicaDubemPosted over 2 years ago

  @mjbaga Thanks for your feedback Marvin, I find it very helpful. I'll definitely make changes.

  1