React JS project w/Sass and Bootstrap

Community feedback

• 

  Matthias•235

  @MatthiasSmithPosted over 3 years ago

  Hi @gelizabeth.

  Looks great! Love the smooth transition between dark and light modes.

  Something I noticed while testing is that refreshing the browser when you're on a country's page causes a 404 error. Is it a router issue?

  And two small things: The title tag of the website is "React App." And the favicon isn't loading in my browser tabs.

  Awesome work!

  2

  ---

  

  Elizabeth•460

  @gelizabethPosted over 3 years ago

  Hi @MatthiasSmith, thank you a lot for your feedback.

  I've fixed those issues. I'm not sure why 404 error happens and I think this happens only when deploying react app to Netlify - to fix that I've added _redirects file to public folder and now it works. Link to problem solution

  Thank you again and have a nice day!

  0
• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @gelizabeth, I'm not sure how helpful this is but I don't really see the issues you mention. Styles load immediately, only the flags take a bit longer, but it's still only a second, if that.

  There are a few flags which don't stretch the width or height of the container both on desktop and mobile (like Aruba or Australia - not sure if that's what you meant?). But honestly viewing the page as a user I'd just think that some flags have a different aspect ratio and that's it? Sorry I can't help more, I'm not really familiar with this challenge!

  I did notice one small thing - I think there's a transition missing on the search field - it toggles between light and dark mode differently than the rest of the page.

  Overall though I think it looks great, it's responsive, the hover states look great, too. You could maybe scale the cards down a tiny bit in :active state?

  Hope this helps at least a little bit lol :D

  2

  ---

  

  Elizabeth•460

  @gelizabethPosted over 3 years ago

  Hi @AgataLiberska, Thank you for your feedback.

  Actually thanks to your comment, when I was thinking how to explain what I wanted to do with that flag images (to do background-size: cover; but to an image tag), I've had an idea to apply this as inline styles directly to flag element in html part and then to adjust it in css. I don't know if this is a good practice, but it works. Thank you a lot again :D

  I've fixed that search field issue and added cards scaling down on hover too. That looks sooo interesting and smooth.

  Thank you, you've helped me a lot!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi there, Elizabeth! 👋

  Well done on this challenge! 👍 Your solution looks good, is responsive, and the light/dark themes work well! 👏

  A tiny idea I have is to perhaps have the country cards break into a two-column layout at around 700px (rather than just a one-column layout), since I think there's room for a two-column layout and there'll be less empty space to the sides of the cards, then. 😉 Just a suggestion! 😀

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Elizabeth•460

  @gelizabethPosted over 3 years ago

  @ApplePieGiraffe Hi! Thank you! I will try to implement that soon. Have a great day! :)

  1