React JS, HTML, CSS, React-router

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @nicnic31, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  1.Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  3.Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Mary Nicole Permejo•10

  @nicnic31Posted about 2 years ago

  @correlucas Hi, thanks for the tips. I'll take note to that. :)

  0
• 

  Techy kem•50

  @ikemefuna123Posted about 2 years ago

  Wow, you did a good job, I was also having the same deployment issue on my first project, but thankfully I figured it out. Are you available for pair programming? I really need a mentor since this platform helps us to develop our skills. PS. I will be waiting for your response. Kindly assist to treat.

  Marked as helpful

  0

  ---

  

  Mary Nicole Permejo•10

  @nicnic31Posted about 2 years ago

  @ikemefuna123 Hi, it's nice to know that someone has encountered the same problem with me. But I am not yet ready for pair programming since I'm busy looking for a job. Still, I'm looking forward to that opportunity someday. Thanks :)

  0