Design comparison
Solution retrospective
I am a react beginner, I will appreciate tips and advices to better my code... Thanks
Community feedback
- @adarshcodesPosted almost 4 years ago
Hi @Steentoons, You did a nice job on this challenge, Great work👏. Let's talk about your solution:
- Design is looking great and the hover effect on the nav link is nice.
- I would recommend you to add
margin-bottom: 50px;
to the .latest-articles-div. - Responsiveness is working smoothly. A small issue I notice is on the mobile view the navigation is a bit more down due to the 6.5em of margin, 5em is looking great to me, and also add
list-style: none;
to the li. - Give HTML issues a shot to fix. Keep it up👍, Happy Coding😀 P.S: I'm also started learning React so any suggestion would be great.
3@SteentoonsPosted almost 4 years agoHey @adarshcodes Thanks for the tips... I will definately look into that
0 - @AryaAnish121Posted almost 4 years ago
Hi Steen,
Nice 95% perfect,
Happy Coding!
2@AryaAnish121Posted almost 4 years ago@Steentoons
Please upvote my comments
It will be great
1 - @grace-snowPosted almost 4 years ago
Hi, once you've fixed the invalid html and the list item styles on that mobile nav, this will be great!
Some bits of font look a bit small to me (like on buttons) but I haven't seen the design so maybe that's how it's meant to be... I just find them hard to read with my eyesight.
The rest all looks great though, well done 👏
1@SteentoonsPosted almost 4 years agoThanks i will check on the font sizes plus the mobile nav
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord