React JS , Context , CSS GRID , FLEXBOX
Design comparison
Solution retrospective
I'm am not fully satisfied with it, so I appreciate your feedbacks
Community feedback
- @htmlHxckerPosted about 3 years ago
First, I think you should go to the Index.html file in your public directory that comes with create-react-app and Change the title and Favicon, I also think Lazy loading would be very wonderful in this case and again it may be overkill but if you do decide to look into it, Here's a package that could help: https://www.npmjs.com/package/react-loading-skeleton.
Regarding Fetch, I saw that you make multiple Fetch requests which in turn slows down the app a lot, what I think you could do is save the fetched data to state so that if I for instance click Afghanistan, and then click back, it doesn't have to re-fetch the app.
Regarding Responsiveness, On Mobile, it looks a bit weird and there's a horizontal scroll that obscures the Dark mode toggle. All in all, you really did well with this and what I've pointed out are just the places I saw you needed imporvement.
Marked as helpful0@moodyomarPosted about 3 years ago@Hakymreality this is awesome! I loved everything you’ve suggest and I think you are absolutely right, especially regarding the fetch data and lazy loading. I wasn’t satisfied with what I’ve done probably because it lack those. Ill check everything and get it fixed. Cheers bro
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord