React JS along with Tailwind CSS

Community feedback

• 

  Raymart Pamplona•16,060

  @pikapikamartPosted over 3 years ago

  Hey, awesome work on this one. Layout in desktop looks great, the responsiveness could be better like making the content adjust more on screen-size and the content is using a fixed width. The mobile layout looks great.

  I don't use tailwind css but for other suggestions on the site, here are some:

  • Always have a main element to wrap the main content of your page. On this one, the div after the #root should be using a main element.
  • Each car icons should be hidden since they are only decorative images so use alt="' and add aria-hidden="true" on it so that it will be totally hidden.
  • Avoid using multiple h1 on page , you should only use 1 per page. Change those into h2 and the make the h1 a screen-reader only text, meaning tit will be using like a sr-only class and it should be the first text-content inside the main element, I expect for you to know this since you are using react by now.
  • learn more is more suited to be using a tag rather than button since it is more likely to be a link to "learn more" about the car.

  Aside from those, great work again on this one.

  Marked as helpful

  0

  ---

  

  Manmohan Singh•100

  @Manmohan7Posted over 3 years ago

  Hi @pikamart

  Thanks for the feedback. I have updated my solution accordingly.

  0