React JS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Kritika, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • To fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • use h1 for the title of card and not a simple div
  • use min-height: 100vh to container classs instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0

  ---

  

  Kritika•100

  @kritika2000Posted about 2 years ago

  Thanks for your suggestions.@denielden

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @kritika2000 You are welcome and keep it up!

  0