React, CSS, JSX

Community feedback

• 

  P

  Joe Kotvas•140

  @joekotvasPosted 11 months ago

  Great work on this component!

  A few quick notes:

  Hover state for article title Don't forget about the yellow link hover state! The article title could also stand to be a heaver font-weight.

  Sizing The way you specified the component width is interesting, but you will have better results if you specify border-box sizing for all elements:

  * {
    box-sizing: border-box;
  }
  

  And then remove the width: 50%; declaration on .card and declare max-width: 24rem; instead.

  Also, if you make your Github repo public, people can view and interact with your code.

  Marked as helpful

  0

  ---

  

  Ridoan Khan Anik•10

  @ridoankhanPosted 11 months ago

  @joekotvas thank you so much for your nice suggestions. That will help me to improve my design.

  0