- your main logo is somehow partially cut off on my mobile
- the
h1element is considered important in a website, it should not be missing. - alt values must be descriptive to aid assistive technology users to visualize the message that is being put across. The idea is to announce the content of the message to the user.
- css nesting, for easy debugging nest pseudo elements. There is no need to have a css like the following
nav-center .nav-menu .nav-link{}when you can just write it as.nav-link {}
Good work
Marked as helpful
@Abduwaasi
Posted
@ChamuMutezva Hello Chamu, it's really a pleasure hearing a feedback from a pro like you. • I also noticed the logo was cut off after I have hosted the website. I will make changes to it ASAP. I will like to hear from you if there is a way to simulate the behavior or website in mobile phone before hosting. I think the result gotten from the developer console is not always the same with what we have on actual mobile phone. • Thanks for mentioning about h1 I never know it's compulsory to have it before.
• on the css nesting issue, I used SASS to write my css code, all those redundant higher order classes are not included in my code. It's SASS that dynamically added those class in my CSS.
After going through the projects you've done on frontend mentor, I'm convinced that I will learn a lot from you. I will be glad if you can share my a contact too reach out to you anytime I'm having issue. Thanks again for the time you took to review my code.
