React

Community feedback

• 

  Higor Neves Marques•45

  @higormarquesPosted over 4 years ago

  Hi, ttran247!

  Your code is careless about the mobile version, you should think in mobile-first every time that you are developing a responsive web page.

  You had set all to be applied only after 480px breakpoint, but we have a lot of mobile phones running with a 320px screen.

  the best approach to deal with it is:

  /* style.css */
  
  
  /* mobile first */
  .some-class {
    ...
  }
  
  /* tablet */
  @media screen and (min-width: 768px) {
    .some-class {
      ...
    }
  }
  
  /* small desktop */
  @media screen and (min-width: 1024px) {
    .some-class {
      ...
    }
  }
  
  /* desktop */
  @media screen and (min-width: 1366px) {
    .some-class {
      ...
    }
  }
  

  Best regards.

  1

  ---

  

  ttran247•10

  @ttran247Posted over 4 years ago

  Thank you for the feedback. I do appreciate it.

  0