React, Bootstrap 5

Community feedback

• 

  Edwin Cheng•360

  @edwinc73Posted 3 months ago

  Hey @sergiy Nice work on this challenge. Some notes for desktop. Long lines of text usually makes it more hard to follow, you can try use a max-width: 24rem... etc to limit this.

  On switching tabs I dont think the content should shift due to different image heights, you can try defining a height of its container so when the image change the container is still there and therefore the height does not change

  in terms of accessibility the red and white buttons on the design doesnt actually pass contrast standards. You could try adjusting the colors but but find just changing the color:black

  For the mobile version Some elements should be display: none, for example, the more info buttons in the features section

  you could increase the padding left and right you give more white spacing around each sections. Actually in mine I tried to use a reusable wrapper called Section which held all my styles for section. This allowed me to create consistent section elements throughout the site.

  For the navigation I would use react to conditionally render the side nav. this sidenav would render in 100vw and 100vh and reuse the nav items

  Marked as helpful

  1

  ---

  

  Sergiy•1,070

  @MrSeagerPosted 3 months ago

  @edwinc73 this is helpful, thanks)

  0