Design comparison
Solution retrospective
This project got complex fast!
I having a hard time organizing my SASS styling (grouping stylings and stuff...)
And is their a way to make theming easier in react where you just keep track of the dark state in one place and not add conditionals everywhere you need it?
Appreciate any feed back! Thanks!
π¦π¦π¦π¦ππ
πMerry Christmasπ
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Hey, iMervinC! π
Nice job on this challenge! π
I suggest,
- Allowing users to mark items as completed by clicking on the name of the item (not just the checkbox to the side).
- Taking a look at your solution report and trying to clear up some of the errors that are there.
- Adding
cursor: pointer
to the theme changer button.
I'm not very familiar with React, but I like to implement light/dark themes by assigning various colors of the page to CSS variables and then overwrite those variables for different themes by toggling classes on/off the
body
with JS. That way, you can keep track of the theme of the page in more or less one place. Here's a nice article on the dark mode that might help. πKeep coding (and happy coding, too)! π
And happy holidays! π
2 - @abhik-bPosted almost 4 years ago
Hi @iMervinC π , Merry Christmasπ π
- your drag n drop sorting is great
- it looks and feels amazing π₯ππ
- I actually took inspiration from context and reducer
Awesome Job π₯, Keep contributing these amazing solutions π
2@iMervinCPosted almost 4 years ago@abhik-b
Thanks!
I used this video as reference on my context and reducer (https://www.youtube.com/watch?v=zxP4oGejqpU&ab_channel=TheFullStackJunkie)
1@abhik-bPosted almost 4 years agoThanks @iMervinC for the video link, I'll definitely check that out π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord