Design comparison
Solution retrospective
This one was challenging and confusing, but also fun.
Is their any fun API you know? Would love to check it out!
How do you get around the linting on useEffect empty dependency array that is used to mimic a componentDidMount? Can't find a working solution on this anywhere.
Any feedback would be appreciated! Thanks!
🎆🎆Happy New Year everybody! 🎊🎊
Community feedback
- @abhik-bPosted almost 4 years ago
Hi @iMervinC 👋
Your solution is fantastic 👌🔥,
- it is responsive💯
- hover animations and loader animations are cool 😎👌
- theme transition is smooth 🔥
Just a opinion 👇
if (this.state.dark) { document.body.classList.remove('light') document.body.classList.add('dark') } else { document.body.classList.remove('dark') document.body.classList.add('light') }
can be reduced to the below code because the variables can be moved to body from dark class and then no need of dark class (just a opinion)
if (this.state.dark) { document.body.classList.remove('light') } else { document.body.classList.add('light') }
Fantastic Job , Keep Contributing these awesome solutions 🚀 and Happy Coding 😇
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord