React App styling SASS and flexbox

Community feedback

• 

  Fernando•160

  @inanocsPosted almost 4 years ago

  Great job! the dark mode transition is smooth and good!

  2
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Mervin 👋, Your solution is absolutely perfect 👏

  I liked the hover state for any of the platforms, it looks responsive and overall theme transition is great. I looked at your code and it is well written.

  Just a opinion I wanted to share -

  1. const icons & const toK are written and required in both the Platform and PlatformBottom files
  2. Please make another file and export const icons & const toK from there and import and use them on both the Platform and PlatformBottom files
  3. this will avoid code duplication and in any case you update any of the const , the change will be available for both the components(Platform and PlatformBottom)

  But that was just a opinion I had as I did not understand why you have written them in both places.

  Great job, Keep contributing your amazing solutions 🚀

  2

  ---

  

  iMervinC•215

  @iMervinCPosted almost 4 years ago

  @abhik-b Yeah I forgot to do that XD. Thanks!! Will do!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, iMervinC! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Good work on this one! I like the fluid transition of the little circle in the toggle-switch! 😀

  I suggest,

  • Making the toggle-switch tabbable so that keyboard users can access and use the toggle-switch.
  • Clearing up your solution report by removing one or two duplicate IDs found on the page. 😉

  Keep coding (and happy coding, too)! 😁

  And happy holidays! 🎄

  1